Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactional - amp_body prop to body_amp for consistency #137

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

djanhjo
Copy link
Contributor

@djanhjo djanhjo commented Mar 30, 2023

Updating Transactional API endpoint properties amp_body amp_plaintext to body_amp body_plaintext to maintain consistency with Newsletters API.

@mike-engel
Copy link
Collaborator

Just a note that this needs to be a major version bump, unless you add backwards compat for the old key names

@djanhjo
Copy link
Contributor Author

djanhjo commented Mar 30, 2023

Just a note that this needs to be a major version bump, unless you add backwards compat for the old key names

Great callout! The API will be backwards compatible.

@mike-engel
Copy link
Collaborator

Great callout! We're staying backwards compatible https://github.com/customerio/edge/pull/499.

Just to be extra clear, your changes here would still be a major bump, since it could break existing uses (unless you handle the old keys)

@djanhjo
Copy link
Contributor Author

djanhjo commented Mar 30, 2023

Great callout! We're staying backwards compatible customerio/edge#499.

Just to be extra clear, your changes here would still be a major bump, since it could break existing uses (unless you handle the old keys)

Thanks Mike! Unless someone has different opinions, I'll be doing a major version bump on all the client libraries (except for Go) instead of supporting both properties (due to consistency and cleanliness).

@djanhjo djanhjo merged commit 473d275 into main Mar 30, 2023
@djanhjo djanhjo deleted the dan.ho_txnl-amp branch March 30, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants